OSDN Git Service

clk: st: avoid uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Mon, 25 Jan 2016 15:54:04 +0000 (16:54 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Sat, 30 Jan 2016 01:20:08 +0000 (17:20 -0800)
commit9849fadfc07eeb2a3699f1ccb7b61f59d2c3c6b8
tree1e3295181d2f54596913719f097b848340fc05bd
parent3d6f1c7212d0823cbc056b1c184c7fe0cfef553a
clk: st: avoid uninitialized variable use

My previous patch fixed some warnings about printing a couple
of variables that are always uninitialized in quadfs_pll_fs660c32_set_rate(),
but I now got a warning that only shows up in some configurations (i.e.
without gcc -Os) about the params.ndiv being used uninitialized in the
error case:

drivers/clk/st/clkgen-fsyn.c: In function 'quadfs_pll_fs660c32_set_rate':
drivers/clk/st/clkgen-fsyn.c:584:75: warning: 'params.ndiv' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/clk/st/clkgen-fsyn.c:574:16: note: 'params.ndiv' was declared here

This changes the error handling so we bail for invalid arguments rather
than continuing with uninitialized data.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/st/clkgen-fsyn.c