OSDN Git Service

ALSA: usb-audio: Fix implicit sync clearance at stopping stream
authorTakashi Iwai <tiwai@suse.de>
Mon, 26 Apr 2021 06:33:49 +0000 (08:33 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 26 Apr 2021 06:37:05 +0000 (08:37 +0200)
commit988cc17552606be67a956cf8cd6ff504cfc5d643
tree6495c8fe777cb6dec691b936e0ea95a700d7b1be
parent316791b556f7c4aeb7a7fea8f400f4434e71d1bf
ALSA: usb-audio: Fix implicit sync clearance at stopping stream

The recent endpoint management change for implicit feedback mode added
a clearance of ep->sync_sink (formerly ep->sync_slave) pointer at
snd_usb_endpoint_stop() to assure no leftover for the feedback from
the already stopped capture stream.  This turned out to cause a
regression, however, when full-duplex streams were running and only a
capture was stopped.  Because of the above clearance of ep->sync_sink
pointer, no more feedback is done, hence the playback will stall.

This patch fixes the ep->sync_sink clearance to be done only after all
endpoints are released, for addressing the regression.

Reported-and-tested-by: Lucas Endres <jaffa225man@gmail.com>
Fixes: bf6313a0ff76 ("ALSA: usb-audio: Refactor endpoint management")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210426063349.18601-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/endpoint.c