OSDN Git Service

drm: mxsfb: Increase number of outstanding requests on V4 and newer HW
authorMarek Vasut <marex@denx.de>
Sun, 20 Jun 2021 22:47:59 +0000 (00:47 +0200)
committerSam Ravnborg <sam@ravnborg.org>
Tue, 27 Jul 2021 19:15:24 +0000 (21:15 +0200)
commit9891cb54445bc65bf156bda416b6215048c7f617
tree295be9e130b928a4b1095ceeb6ae66f94b4ce76a
parent0c9856e4edcdcac22d65618e8ceff9eb41447880
drm: mxsfb: Increase number of outstanding requests on V4 and newer HW

In case the DRAM is under high load, the MXSFB FIFO might underflow
and that causes visible artifacts. This could be triggered on i.MX8MM
using e.g. "$ memtester 128M" on a device with 1920x1080 panel. The
first "Stuck Address" test of the memtester will completely corrupt
the image on the panel and leave the MXSFB FIFO in odd state.

To avoid this underflow, increase number of outstanding requests to
DRAM from 2 to 16, which is the maximum. This mitigates the issue
and it can no longer be triggered.

Fixes: 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Abrecht <public@danielabrecht.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210620224759.189351-1-marex@denx.de
drivers/gpu/drm/mxsfb/mxsfb_drv.c
drivers/gpu/drm/mxsfb/mxsfb_drv.h
drivers/gpu/drm/mxsfb/mxsfb_kms.c
drivers/gpu/drm/mxsfb/mxsfb_regs.h