OSDN Git Service

net: gianfar: Add of_node_put() before goto statement
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Tue, 18 Aug 2020 18:52:41 +0000 (00:22 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Aug 2020 20:12:12 +0000 (13:12 -0700)
commit989e4da042ca4a56bbaca9223d1a93639ad11e17
tree81a74249028e78ae530cf9518d9dbdadc348cfa3
parent5680790b2d85b9c920ad9f626289ccc2c4fbe244
net: gianfar: Add of_node_put() before goto statement

Every iteration of for_each_available_child_of_node() decrements
reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in gianfar.c by inserting of_node_put()
before the goto statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c