OSDN Git Service

usb: typec: unlock dp->lock on error exit path, and also zero ret if successful
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Jul 2018 13:36:47 +0000 (14:36 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Jul 2018 14:36:19 +0000 (16:36 +0200)
commit98a1a0c7a321a46e805df289c7d385a9b1b4c661
tree12c51af5b7a1cdfce2ab02f640091a840af7900b
parent11b71782c1d10d9bccc31825cf84291cd7588a1e
usb: typec: unlock dp->lock on error exit path, and also zero ret if successful

One of the error handling paths forgets to unlock dp->lock on the error
exit path leading to a potential lock-up.  Also the return path for a
successful call to the function configuration_store can return an
uninitialized error return code if dp->alt->active is false, so ensure
ret is zeroed on the successful exit path to avoid garbage being returned.

Detected by CoverityScan, CID#1471597 ("Unitialized scalar variable")

Fixes: 0e3bb7d6894d ("usb: typec: Add driver for DisplayPort alternate mode")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/altmodes/displayport.c