OSDN Git Service

drm/i915/bios: assume vbt is 4-byte aligned into oprom
authorLucas De Marchi <lucas.demarchi@intel.com>
Tue, 26 Nov 2019 22:51:10 +0000 (14:51 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Mon, 2 Dec 2019 21:54:23 +0000 (13:54 -0800)
commit98cf5c9a482d975b91d2cf00e09c061b535b8ee4
tree3a65c2362523def6817a5a3fb375aac7a5660d53
parent2cded152ad43875e8e01cef328e886861129c3a9
drm/i915/bios: assume vbt is 4-byte aligned into oprom

The unaligned ioread32() will make us read byte by byte looking for the
vbt. We could just as well have done a ioread8() + a shift and avoid the
extra confusion on how we are looking for "$VBT".

However when using ACPI it's guaranteed the VBT is 4-byte aligned
per spec, so we can probably assume it here as well.

v2: do not try to simplify the loop by eliminating the auxiliary counter
(Jani and Ville)

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191126225110.8127-4-lucas.demarchi@intel.com
drivers/gpu/drm/i915/display/intel_bios.c