OSDN Git Service

mnt: Fail collect_mounts when applied to unmounted mounts
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 7 Jan 2015 20:28:26 +0000 (14:28 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Jun 2015 15:20:47 +0000 (08:20 -0700)
commit9993cbfde223f91ad29c5d002f6711fceff75219
treea256d230951a4d36073b5e5e117b9dd6ebbe749c
parent8b660f48b5734edc272a008a34207cf1a249fcf7
mnt: Fail collect_mounts when applied to unmounted mounts

commit cd4a40174b71acd021877341684d8bb1dc8ea4ae upstream.

The only users of collect_mounts are in audit_tree.c

In audit_trim_trees and audit_add_tree_rule the path passed into
collect_mounts is generated from kern_path passed an audit_tree
pathname which is guaranteed to be an absolute path.   In those cases
collect_mounts is obviously intended to work on mounted paths and
if a race results in paths that are unmounted when collect_mounts
it is reasonable to fail early.

The paths passed into audit_tag_tree don't have the absolute path
check.  But are used to play with fsnotify and otherwise interact with
the audit_trees, so again operating only on mounted paths appears
reasonable.

Avoid having to worry about what happens when we try and audit
unmounted filesystems by restricting collect_mounts to mounts
that appear in the mount tree.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/namespace.c