OSDN Git Service

arm64: kexec_file: Avoid temp buffer for RNG seed
authorGeorge Spelvin <lkml@SDF.ORG>
Mon, 30 Mar 2020 17:38:01 +0000 (17:38 +0000)
committerWill Deacon <will@kernel.org>
Tue, 28 Apr 2020 12:55:51 +0000 (13:55 +0100)
commit99ee28d99607d15c6b88c4a9b9fb4a9f0ebf598c
tree7715e2cea292b716d4042c947891333a6cadbd30
parent348a625deef13d7f8537b9704d29d05cafdd8e72
arm64: kexec_file: Avoid temp buffer for RNG seed

After using get_random_bytes(), you want to wipe the buffer
afterward so the seed remains secret.

In this case, we can eliminate the temporary buffer entirely.
fdt_setprop_placeholder() returns a pointer to the property value
buffer, allowing us to put the random data directly in there without
using a temporary buffer at all.  Faster and less stack all in one.

Signed-off-by: George Spelvin <lkml@sdf.org>
Acked-by: Will Deacon <will@kernel.org>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: https://lore.kernel.org/r/20200330173801.GA9199@SDF.ORG
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/machine_kexec_file.c