OSDN Git Service

net: stmmac: Fix VLAN filter delete timeout issue in Intel mGBE SGMII
authorOng Boon Leong <boon.leong.ong@intel.com>
Fri, 5 Mar 2021 05:49:30 +0000 (13:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 Mar 2021 20:59:32 +0000 (12:59 -0800)
commit9a7b3950c7e15968e23d83be215e95ccc7c92a53
tree526ee518ee2250d24662267062a8dc91570b7658
parent6650d31f21b8a0043613ae0a4a2e42e49dc20b2d
net: stmmac: Fix VLAN filter delete timeout issue in Intel mGBE SGMII

For Intel mGbE controller, MAC VLAN filter delete operation will time-out
if serdes power-down sequence happened first during driver remove() with
below message.

[82294.764958] intel-eth-pci 0000:00:1e.4 eth2: stmmac_dvr_remove: removing driver
[82294.778677] intel-eth-pci 0000:00:1e.4 eth2: Timeout accessing MAC_VLAN_Tag_Filter
[82294.779997] intel-eth-pci 0000:00:1e.4 eth2: failed to kill vid 0081/0
[82294.947053] intel-eth-pci 0000:00:1d.2 eth1: stmmac_dvr_remove: removing driver
[82295.002091] intel-eth-pci 0000:00:1d.1 eth0: stmmac_dvr_remove: removing driver

Therefore, we delay the serdes power-down to be after unregister_netdev()
which triggers the VLAN filter delete.

Fixes: b9663b7ca6ff ("net: stmmac: Enable SERDES power up/down sequence")
Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c