OSDN Git Service

dma-buf/sw_sync: clean up list before signaling the fence
authorGustavo Padovan <gustavo.padovan@collabora.com>
Sat, 29 Jul 2017 15:22:16 +0000 (12:22 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Dec 2017 21:01:55 +0000 (22:01 +0100)
commit9ae85fabdfc0c74c2ac32219e116546e2a5a6309
tree56ed071e2c8f9ad69f4c3e77657dae247ec8744a
parent4496b88c06744a9a92088e1924c0b39e225898b2
dma-buf/sw_sync: clean up list before signaling the fence

commit 3792b7c1a70815fe4e954221c096f9278638fd21 upstream.

If userspace already dropped its own reference by closing the sw_sync
fence fd we might end up in a deadlock where
dma_fence_is_signaled_locked() will trigger the release of the fence and
thus try to hold the lock to remove the fence from the list.

dma_fence_is_signaled_locked() tries to release/free the fence and hold
the lock in the process.

We fix that by changing the order operation and clean up the list and
rb-tree first.

v2: Drop fence get/put dance and manipulate the list first (Chris Wilson)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20170729152217.8362-2-gustavo@padovan.org
[s/dma_fence/fence/g - gregkh]
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma-buf/sw_sync.c