OSDN Git Service

(root) / tomoyo / tomoyo-test1.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 321488d) | patch
drm/amd/amdgpu: Fix up locking etc in amdgpu_debugfs_gprwave_ioctl()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 25 May 2023 08:04:51 +0000 (11:04 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Jun 2023 15:10:04 +0000 (11:10 -0400)
commit9c9d501b28a00f4365632260df6cae488a905af7
treec665772e9358278f1a42b89ccbe423dd6304d752tree | snapshot
parent321488d180c2f5c1811a0ba7b18d18c7af87739bcommit | diff
drm/amd/amdgpu: Fix up locking etc in amdgpu_debugfs_gprwave_ioctl()

There are two bugs here.
1) Drop the lock if copy_from_user() fails.
2) If the copy fails then the correct error code is -EFAULT instead of
   -EINVAL.

I also broke up the long line and changed "sizeof rd->id" to
"sizeof(rd->id)".

Fixes: 553f973a0d7b ("drm/amd/amdgpu: Update debugfs for XCC support (v3)")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c diff | blob | history
This is a test repository.
About OSDN
Find Software
Develop Software
Help