OSDN Git Service

sfc: take correct lock in ef100_reset()
authorEdward Cree <ecree@solarflare.com>
Tue, 18 Aug 2020 12:43:57 +0000 (13:43 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Aug 2020 19:49:12 +0000 (12:49 -0700)
commit9cbbc451098ec1e9942886023203b2247dec94bd
tree38c2a77a4f2e7c441ec132da06b97cac368196b6
parentdb06ea341fcd1752fbdb58454507faa140e3842f
sfc: take correct lock in ef100_reset()

When downing and upping the ef100 filter table, we need to take a write
 lock on efx->filter_sem, not just a read lock, because we may kfree()
 the table pointers.
Without this, resets cause a WARN_ON from efx_rwsem_assert_write_locked().

Fixes: a9dc3d5612ce ("sfc_ef100: RX filter table management and related gubbins")
Signed-off-by: Edward Cree <ecree@solarflare.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef100_nic.c