OSDN Git Service

drm/mgag200: Do not call drm_atomic_add_affected_planes()
authorJavier Martinez Canillas <javierm@redhat.com>
Tue, 11 Oct 2022 16:51:33 +0000 (18:51 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Thu, 13 Oct 2022 07:17:03 +0000 (09:17 +0200)
commit9cebffdf0d9c2b045fa3ecde43a2c0014953087a
treefd1c44fde7ea96b344ef73465389f58ffa1daa21
parent9cf06d6ef7fd08adf51568b704ab7ba6007b6fe8
drm/mgag200: Do not call drm_atomic_add_affected_planes()

There's no need to add planes to the atomic state. Remove the call
to drm_atomic_add_affected_planes() from mgag200.

On full modesets, the DRM helpers already add a CRTC's planes to the
atomic state; see drm_atomic_helper_check_modeset(). There's no reason
to call drm_atomic_add_affected_planes() unconditionally in the CRTC's
atomic_check() in mgag200. It's also too late, as the atomic_check()
of the added planes will not be called before the commit.

Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20221011165136.469750-2-javierm@redhat.com
drivers/gpu/drm/mgag200/mgag200_mode.c