OSDN Git Service

media: staging: rkisp1: cap: fix timeout when stopping the stream
authorHelen Koike <helen.koike@collabora.com>
Fri, 6 Nov 2020 23:02:36 +0000 (00:02 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 17 Nov 2020 05:59:13 +0000 (06:59 +0100)
commit9d28a76d406b118df484ef3fd160c02c6cd1d6e7
tree95622a8f213cd11f369313bee0c52d954220cb80
parent167faadfcf9339088910e9e85a1b711fcbbef8e9
media: staging: rkisp1: cap: fix timeout when stopping the stream

The dma engine should be stopped first.
The driver waits for an interrupt to stop the stream in a known state
after a frame.
If rkisp1_cap_stream_disable() is called after stopping the rest of the
pipeline, then most likely the interrupt won't arrive, we'll get a
timeout and debugfs variables mp_stop_timeout or sp_stop_timeout will
be incremented.

Fixes: 37db540bb9d1f ("media: staging: rkisp1: cap: refactor enable/disable stream to allow multistreaming")
Signed-off-by: Helen Koike <helen.koike@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/rkisp1/rkisp1-capture.c