OSDN Git Service

media: i2c: mt9v111: Fix v4l2-ctrl error handling
authorJacopo Mondi <jacopo+renesas@jmondi.org>
Fri, 3 Aug 2018 10:40:58 +0000 (12:40 +0200)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 12 Sep 2018 10:44:01 +0000 (06:44 -0400)
commit9d2ac5f4bec00a0697ab77c999ef38753b3cb900
tree9535241f16c9267f4a121ab80a08cfe3c52fa690
parent3799eca51c5be3cd76047a582ac52087373b54b3
media: i2c: mt9v111: Fix v4l2-ctrl error handling

Fix error handling of v4l2_ctrl creation by inspecting the ctrl.error flag
instead of testing for each returned value correctness.

As reported by Dan Carpenter returning PTR_ERR() on the v4l2_ctrl_new_std()
return value is also wrong, as that function return NULL on error.

While at there re-order the cleanup path to respect the operation inverse
order.

Fixes: aab7ed1c "media: i2c: Add driver for Aptina MT9V111"
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/mt9v111.c