OSDN Git Service

f2fs: fix race in between GC and atomic open
authorChao Yu <yuchao0@huawei.com>
Tue, 17 Apr 2018 09:51:28 +0000 (17:51 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 9 Jul 2018 00:28:35 +0000 (17:28 -0700)
commit9d77ded0a71d5174ce8c4657b8b49a847122b143
tree3d89d22e1dd55216f54e4434779dacd51e0cba78
parent0d17eb90b56aafeea4d7053e8eba8dd0cffaee39
f2fs: fix race in between GC and atomic open

Thread GC thread
- f2fs_ioc_start_atomic_write
 - get_dirty_pages
 - filemap_write_and_wait_range
- f2fs_gc
 - do_garbage_collect
  - gc_data_segment
   - move_data_page
    - f2fs_is_atomic_file
    - set_page_dirty
 - set_inode_flag(, FI_ATOMIC_FILE)

Dirty data page can still be generated by GC in race condition as
above call stack.

This patch adds fi->dio_rwsem[WRITE] in f2fs_ioc_start_atomic_write
to avoid such race.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/file.c