OSDN Git Service

hw/arm/smmu-common: Avoid using inlined functions with external linkage
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Fri, 16 Dec 2022 21:49:24 +0000 (22:49 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 5 Jan 2023 14:51:27 +0000 (14:51 +0000)
commit9de9fa5cf2b26b13e895516c6fa1671af6994a6a
tree146ecac2a5374842b33b3e77bfb3a4862333af99
parent1e793dd69680a42d3d4ea25450e006322817e0dd
hw/arm/smmu-common: Avoid using inlined functions with external linkage

When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)")
and building with -Wall we get:

  hw/arm/smmu-common.c:173:33: warning: static function 'smmu_hash_remove_by_asid_iova' is used in an inline function with external linkage [-Wstatic-in-inline]
  hw/arm/smmu-common.h:170:1: note: use 'static' to give inline function 'smmu_iotlb_inv_iova' internal linkage
    void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
    ^
    static

None of our code base require / use inlined functions with external
linkage. Some places use internal inlining in the hot path. These
two functions are certainly not in any hot path and don't justify
any inlining, so these are likely oversights rather than intentional.

Reported-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20221216214924.4711-3-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/arm/smmu-common.c