OSDN Git Service

s390/dasd: Fix operational path inconsistency
authorJan Höppner <hoeppner@linux.ibm.com>
Thu, 8 Oct 2020 13:13:33 +0000 (15:13 +0200)
committerJens Axboe <axboe@kernel.dk>
Mon, 16 Nov 2020 15:14:38 +0000 (08:14 -0700)
commit9e34c8ba91697cb7441805c36d92ab3e695df6e0
tree5a1efed44edd453f2a5cc772db3e92a92a79aebb
parent460181217a2496defc6c279b0a7eb810b05b9145
s390/dasd: Fix operational path inconsistency

During online processing and setting up a DASD device, the configuration
data for operational paths is read and validated two times
(dasd_eckd_read_conf()). The first time to provide information that are
necessary for the LCU setup. A second time after the LCU setup as a
device might report different configuration data then.

When the configuration setup for each operational path is being
validated, an initial call to dasd_eckd_clear_conf_data() is issued.
This call wipes all previously available configuration data and path
information for each path.
However, the operational path mask is not updated during this process.

As a result, the stored operational path mask might no longer correspond
to the operational paths mask reported by the CIO layer, as several
paths might be gone between the two dasd_eckd_read_conf() calls.

This inconsistency leads to more severe issues in later path handling
changes. Fix this by removing the channel paths from the operational
path mask during the dasd_eckd_clear_conf_data() call.

Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/s390/block/dasd_eckd.c