OSDN Git Service

iommu: dart: DART_T8110_ERROR range should be 0 to 5
authorEric Curtin <ecurtin@redhat.com>
Wed, 1 Feb 2023 12:42:58 +0000 (12:42 +0000)
committerJoerg Roedel <jroedel@suse.de>
Fri, 3 Feb 2023 10:10:40 +0000 (11:10 +0100)
commit9e6a1825aca8568f624abeeb047969c72aa4c183
tree12444f4da57309ad8e354c38cf46ae63a39cee2f
parentcf5c1c87c2391649e05e58ecc6dfc3dc5ebebc05
iommu: dart: DART_T8110_ERROR range should be 0 to 5

This was detected by smatch as one "else if" statement could never be
reached. Confirmed bit order by comparing with python implementation [1].

drivers/iommu/apple-dart.c:991 apple_dart_t8110_irq()
warn: duplicate check 'error_code == ((((1))) << (3))'
  (previous on line 989)

Link: https://github.com/AsahiLinux/m1n1/commit/96b2d584feec1e3f7bfa
Fixes: d8bcc870d99d ("iommu: dart: Add t8110 DART support")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20230201124257.7801-1-ecurtin@redhat.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/apple-dart.c