OSDN Git Service

drm/amdgpu: Use local64_try_cmpxchg in amdgpu_perf_read
authorUros Bizjak <ubizjak@gmail.com>
Mon, 3 Jul 2023 15:00:59 +0000 (17:00 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 9 Aug 2023 22:08:51 +0000 (18:08 -0400)
commit9e761bff03e137fca0c41fd3bcc3e88167d59dc1
tree3022d4c81133a842ca8ef7838240a0ff3d4d61bb
parent59070fd9ccea58c3363d39f69c25fa98c71eb02f
drm/amdgpu: Use local64_try_cmpxchg in amdgpu_perf_read

Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old
in amdgpu_perf_read.  x86 CMPXCHG instruction returns success in ZF flag,
so this change saves a compare after cmpxchg (and related move instruction
in front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails. There is no need to re-read the value in the loop.

No functional change intended.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c