OSDN Git Service

net: bridge: propagate extack through store_bridge_parm
authorVladimir Oltean <vladimir.oltean@nxp.com>
Sat, 13 Feb 2021 20:43:16 +0000 (22:43 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Feb 2021 01:38:11 +0000 (17:38 -0800)
commit9e781401cbfcd83c4d766b4c6c5efce8348d4d13
treef160bbe6e715476a92b6c611acfc06ba77f17aa3
parent7a572964e0c454b0ead57174c964bd7a2d498455
net: bridge: propagate extack through store_bridge_parm

The bridge sysfs interface stores parameters for the STP, VLAN,
multicast etc subsystems using a predefined function prototype.
Sometimes the underlying function being called supports a netlink
extended ack message, and we ignore it.

Let's expand the store_bridge_parm function prototype to include the
extack, and just print it to console, but at least propagate it where
applicable. Where not applicable, create a shim function in the
br_sysfs_br.c file that discards the extra function argument.

This patch allows us to propagate the extack argument to
br_vlan_set_default_pvid, br_vlan_set_proto and br_vlan_filter_toggle,
and from there, further up in br_changelink from br_netlink.c.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_netlink.c
net/bridge/br_private.h
net/bridge/br_sysfs_br.c
net/bridge/br_vlan.c