OSDN Git Service

xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_device_alloc
authorJia-Ju Bai <baijiaju1990@gmail.com>
Mon, 9 Apr 2018 15:04:12 +0000 (23:04 +0800)
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>
Mon, 16 Apr 2018 14:20:21 +0000 (10:20 -0400)
commit9eb5f15b47b69847bfceb94350bd68fbdbf829e3
tree041219820c19cb917a6e0fdc5aef4ecdd3001745
parentbb52e3169cb7dd5a9deea39b94342fce36235a5b
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_device_alloc

pcistub_device_alloc() is never called in atomic context.

The call chain ending up at pcistub_device_alloc() is:
[1] pcistub_device_alloc() <- pcistub_seize() <- pcistub_probe()
pcistub_probe() is only set as ".probe" in struct pci_driver.
This function is not called in atomic context.

Despite never getting called from atomic context,
pcistub_device_alloc() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
drivers/xen/xen-pciback/pci_stub.c