OSDN Git Service

mfd: sm501: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 22 Jan 2019 16:58:20 +0000 (10:58 -0600)
committerLee Jones <lee.jones@linaro.org>
Thu, 7 Feb 2019 10:43:09 +0000 (10:43 +0000)
commit9f208eca4f2faa38def458f663ec142a0b6f451b
treefa891d17596b97766b5d0e8e2cd49ab3808233de
parentae7b8eda27b33b1f688dfdebe4d46f690a8f9162
mfd: sm501: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/sm501.c