OSDN Git Service

batman-adv: Avoid WARN_ON timing related checks
authorSven Eckelmann <sven@narfation.org>
Tue, 18 May 2021 19:00:27 +0000 (21:00 +0200)
committerSimon Wunderlich <sw@simonwunderlich.de>
Tue, 18 May 2021 19:10:01 +0000 (21:10 +0200)
commit9f460ae31c4435fd022c443a6029352217a16ac1
treeefee98392b0efe46553714a7f9acfc00c21683c7
parentb741596468b010af2846b75f5e75a842ce344a6e
batman-adv: Avoid WARN_ON timing related checks

The soft/batadv interface for a queued OGM can be changed during the time
the OGM was queued for transmission and when the OGM is actually
transmitted by the worker.

But WARN_ON must be used to denote kernel bugs and not to print simple
warnings. A warning can simply be printed using pr_warn.

Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Reported-by: syzbot+c0b807de416427ff3dd1@syzkaller.appspotmail.com
Fixes: ef0a937f7a14 ("batman-adv: consider outgoing interface in OGM sending")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/bat_iv_ogm.c