OSDN Git Service

ASoC: soc-pcm: Move debugfs removal out of spinlock
authorTakashi Iwai <tiwai@suse.de>
Wed, 19 Jan 2022 15:52:49 +0000 (16:52 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 28 Jan 2022 15:59:18 +0000 (15:59 +0000)
commit9f620684c1ef5a002b6622ecc7b5818e81252f48
tree19585edbcba394a2d9114f460f058d324956b39a
parent3c75c0ea5da749bd1efebd1387f2e5011b8c7d78
ASoC: soc-pcm: Move debugfs removal out of spinlock

The recent fix for DPCM locking also covered the loop in
dpcm_be_disconnect() with the FE stream lock.  This caused an
unexpected side effect, thought: calling debugfs_remove_recursive() in
the spinlock may lead to lockdep splats as the code there assumes the
SOFTIRQ-safe context.

For avoiding the problem, this patch changes the disconnection
procedure to two phases: at first, the matching entries are removed
from the linked list, then the resources are freed outside the lock.

Fixes: b7898396f4bb ("ASoC: soc-pcm: Fix and cleanup DPCM locking")
Reported-and-tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20220119155249.26754-3-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c