OSDN Git Service

bpf: Fix resetting logic for unreferenced kptrs
authorJules Irenge <jbi.octave@gmail.com>
Wed, 7 Sep 2022 15:24:20 +0000 (16:24 +0100)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 7 Sep 2022 18:15:18 +0000 (11:15 -0700)
commit9fad7fe5b29803584c7f17a2abe6c2936fec6828
tree44399153a3ed1c94fb81141e31da24523542807c
parent53e80a39ff9fc61651e0d3f7614af5d47c5bd1fe
bpf: Fix resetting logic for unreferenced kptrs

Sparse reported a warning at bpf_map_free_kptrs()
"warning: Using plain integer as NULL pointer"
During the process of fixing this warning, it was discovered that the current
code erroneously writes to the pointer variable instead of deferencing and
writing to the actual kptr. Hence, Sparse tool accidentally helped to uncover
this problem. Fix this by doing WRITE_ONCE(*p, 0) instead of WRITE_ONCE(p, 0).

Note that the effect of this bug is that unreferenced kptrs will not be cleared
during check_and_free_fields. It is not a problem if the clearing is not done
during map_free stage, as there is nothing to free for them.

Fixes: 14a324f6a67e ("bpf: Wire up freeing of referenced kptr")
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Link: https://lore.kernel.org/r/Yxi3pJaK6UDjVJSy@playground
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/syscall.c