OSDN Git Service

ipv4: remove BUG_ON() from fib_compute_spec_dst
authorLorenzo Bianconi <lorenzo.bianconi@redhat.com>
Fri, 27 Jul 2018 16:15:46 +0000 (18:15 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 29 Jul 2018 02:06:12 +0000 (19:06 -0700)
commit9fc12023d6f51551d6ca9ed7e02ecc19d79caf17
treed8ebbe02f2b8d4e7b57291af9acd485d79c22fed
parentab123fe071c9aa9680ecd62eb080eb26cff4892c
ipv4: remove BUG_ON() from fib_compute_spec_dst

Remove BUG_ON() from fib_compute_spec_dst routine and check
in_dev pointer during flowi4 data structure initialization.
fib_compute_spec_dst routine can be run concurrently with device removal
where ip_ptr net_device pointer is set to NULL. This can happen
if userspace enables pkt info on UDP rx socket and the device
is removed while traffic is flowing

Fixes: 35ebf65e851c ("ipv4: Create and use fib_compute_spec_dst() helper")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_frontend.c