OSDN Git Service

omap2fb: Fix stack memory disclosure
authorVlad Tsyrklevich <vlad@tsyrklevich.net>
Fri, 11 Jan 2019 13:34:38 +0000 (14:34 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Fri, 11 Jan 2019 13:34:38 +0000 (14:34 +0100)
commita01421e4484327fe44f8e126793ed5a48a221e24
tree9775a2ba7656377541b5ce2ff581948164c08080
parent399382f8018204407174f0229b4087d40e1cdc82
omap2fb: Fix stack memory disclosure

Using [1] for static analysis I found that the OMAPFB_QUERY_PLANE,
OMAPFB_GET_COLOR_KEY, OMAPFB_GET_DISPLAY_INFO, and OMAPFB_GET_VRAM_INFO
cases could all leak uninitialized stack memory--either due to
uninitialized padding or 'reserved' fields.

Fix them by clearing the shared union used to store copied out data.

[1] https://github.com/vlad902/kernel-uninitialized-memory-checker

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
Fixes: b39a982ddecf ("OMAP: DSS2: omapfb driver")
Cc: security@kernel.org
[b.zolnierkie: prefix patch subject with "omap2fb: "]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c