OSDN Git Service

qom: Avoid leaking str and bool properties on failure
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 4 Mar 2014 14:28:18 +0000 (15:28 +0100)
committerAndreas Färber <afaerber@suse.de>
Wed, 12 Mar 2014 19:13:02 +0000 (20:13 +0100)
commita01aedc8d32e6f5b08a4041b62be3c5fab7a3382
tree747d980eee9fa1cc567ede14ed208c4685359593
parent7b0309490cb108d881a0c66d6b350b4db7b3b4ac
qom: Avoid leaking str and bool properties on failure

When object_property_add_str() and object_property_add_bool() fail, they
leak their internal StringProperty and BoolProperty structs.  Remember
to free the structs on error.

Luckily this is a low-impact memory leak since most QOM properties are
static qdev properties that will never take the error case.
object_property_add() only fails if the property name is already in use.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Andreas Färber <afaerber@suse.de>
qom/object.c