OSDN Git Service

block: fix double bio queue when merging in cached request path
authorJens Axboe <axboe@kernel.dk>
Thu, 2 Dec 2021 19:43:46 +0000 (12:43 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 3 Dec 2021 02:39:01 +0000 (19:39 -0700)
commita08ed9aae8a3d2321ef378d6581cc87a3fb75b44
treedf0fe69900a59fa4f9e3098c19b7e82f010d3e7f
parent373b5416b4b03ebda5d8f0605b81eff0dc76ebcf
block: fix double bio queue when merging in cached request path

When we attempt to merge off the cached request path, we return NULL
if successful. This makes the caller believe that it's should allocate
a new request, and hence we end up with the bio both merged and associated
with a new request. This, predictably, leads to all sorts of crashes.

Pass in a pointer to the bio pointer, and clear it for the merge case.
Then the caller knows that the bio is already queued, and no new requests
need to get allocated.

Fixes: 5b13bc8a3fd5 ("blk-mq: cleanup request allocation")
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c