OSDN Git Service

x86/uv/time: Use a flexible array in struct uv_rtc_timer_head
authorGustavo A. R. Silva <gustavoars@kernel.org>
Thu, 1 Oct 2020 14:56:08 +0000 (09:56 -0500)
committerBorislav Petkov <bp@suse.de>
Thu, 1 Oct 2020 16:47:39 +0000 (18:47 +0200)
commita0947081af2ac9549e6ba19877456730713bde23
treef4f3f52d31d6f20be61ce643da601b974bc95456
parenta1b8638ba1320e6684aa98233c15255eb803fac7
x86/uv/time: Use a flexible array in struct uv_rtc_timer_head

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The
older style of one-element or zero-length arrays should no longer be
used[2].

struct uv_rtc_timer_head contains a one-element array cpu[1]. Switch it
to a flexible array and use the struct_size() helper to calculate the
allocation size. Also, save some heap space in the process[3].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays
[3] https://lore.kernel.org/lkml/20200518190114.GA7757@embeddedor/

 [ bp: Massage a bit. ]

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: Steve Wahl <steve.wahl@hpe.com>
Link: https://lkml.kernel.org/r/20201001145608.GA10204@embeddedor
arch/x86/platform/uv/uv_time.c