OSDN Git Service

MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Mon, 21 Jan 2019 02:48:49 +0000 (11:48 +0900)
committerPaul Burton <paul.burton@mips.com>
Wed, 23 Jan 2019 01:35:57 +0000 (17:35 -0800)
commita0f0b69f2c15c12eb45b4e8d76f704ba9bc9c126
treea19bb0313e39efc7497df951bb0e90d9b122dc74
parent7e280f6b0549f3c3e9e94206954d49f87c2048d0
MIPS: remove meaningless generic-(CONFIG_GENERIC_CSUM) += checksum.h

This line is weird in multiple ways.

(CONFIG_GENERIC_CSUM) might be a typo of $(CONFIG_GENERIC_CSUM).

Even if you add '$' to it, $(CONFIG_GENERIC_CSUM) is never evaluated
to 'y' because scripts/Makefile.asm-generic does not include
include/config/auto.conf. So, the asm-generic wrapper of checksum.h
is never generated.

Even if you manage to generate it, it is never included by anyone
because MIPS has the checkin header with the same file name:

  arch/mips/include/asm/checksum.h

As you see in the top Makefile, the checkin headers are included before
generated ones.

  LINUXINCLUDE    := \
                  -I$(srctree)/arch/$(SRCARCH)/include \
                  -I$(objtree)/arch/$(SRCARCH)/include/generated \
                  ...

Commit 4e0748f5beb9 ("MIPS: Use generic checksum functions for MIPS R6")
already added the asm-generic fallback code in the checkin header:

  #ifdef CONFIG_GENERIC_CSUM
  #include <asm/generic/checksum.h>
  #else
    ...
  #endif

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-kernel@vger.kernel.org
arch/mips/include/asm/Kbuild