OSDN Git Service

scsi: mpi3mr: Fix error codes in mpi3mr_report_manufacture()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 15 Sep 2022 11:10:30 +0000 (14:10 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Sep 2022 02:04:02 +0000 (22:04 -0400)
commita113c02f57388fc4d179ac5580303d97a000ede7
tree777bd939d3823fe1d73f4877e3cc508cc54936fc
parent32e7e06f60e78bca28fc6bb7f9dd54177750c331
scsi: mpi3mr: Fix error codes in mpi3mr_report_manufacture()

There are three error paths which return success:

1) Propagate the error code from mpi3mr_post_transport_req() if it fails.

2) Return -EINVAL if "ioc_status != MPI3_IOCSTATUS_SUCCESS".

3) Return -EINVAL if "le16_to_cpu(mpi_reply.response_data_length) !=
   sizeof(struct rep_manu_reply)"

Link: https://lore.kernel.org/r/YyMIJh1HU2Qz9+Rs@kili
Fixes: 2bd37e284914 ("scsi: mpi3mr: Add framework to issue MPT transport cmds")
Acked-by: Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr_transport.c