OSDN Git Service

ice: fix potential infinite loop
authorColin Ian King <colin.king@canonical.com>
Fri, 2 Aug 2019 15:52:17 +0000 (16:52 +0100)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 27 Aug 2019 06:30:26 +0000 (23:30 -0700)
commita1199d679af4103acdc0fdc17ae9c1274733d673
tree5f19a465fd60c7f511a0ba739d4bd202331307d9
parent35b4f4372f91d79632e8881b8c4a8f7802ff12f4
ice: fix potential infinite loop

The loop counter of a for-loop is a u8 however this is being compared
to an int upper bound and this can lead to an infinite loop if the
upper bound is greater than 255 since the loop counter will wrap back
to zero. Fix this potential issue by making the loop counter an int.

Addresses-Coverity: ("Infinite loop")
Fixes: c7aeb4d1b9bf ("ice: Disable VFs until reset is completed")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c