OSDN Git Service

drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the spinlock
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 4 Sep 2018 13:12:07 +0000 (14:12 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 4 Sep 2018 15:01:14 +0000 (16:01 +0100)
commita167b1e1319cac8894a88e9ea05a13be05b46d87
treee86a367f0af8fafe401c754c994d170285157ff6
parentb212f0a470eeb62a8eaa95f51b3cdbc457f687a8
drm/i915: Pull intel_uncore_arm_unclaimed_mmio_detection() under the spinlock

Elsewhere we manipulate uncore.unclaimed_mmio_check and
i915_param.mmio_debug under the irq lock (e.g. preserving the current
value across a user forcewake grab), but do not protect the manipulation
inside intel_uncore_arm_unclaimed_mmio_detection() from concurrent
access, even from itself. This is an issue as we do call
arm_unclaimed_mmio_detection from multiple threads without coordination.

Suggested-by: Mika Kuoppala <mika.kuoppala@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intelcom>
Link: https://patchwork.freedesktop.org/patch/msgid/20180904131207.17563-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_uncore.c