OSDN Git Service

net: hns: fix uninitialized data use
authorArnd Bergmann <arnd@arndb.de>
Fri, 24 Mar 2017 22:02:49 +0000 (23:02 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 26 Mar 2017 03:05:32 +0000 (20:05 -0700)
commita17f1861b5ea4327f9f35e9edb3c5fadceaa7c64
tree875732971919799dfc0abd3f8b122826a49078c2
parentb1977682a3858b5584ffea7cfb7bd863f68db18d
net: hns: fix uninitialized data use

When dev_dbg() is enabled, we print uninitialized data, as gcc-7.0.1
now points out:

ethernet/hisilicon/hns/hns_dsaf_main.c: In function 'hns_dsaf_set_promisc_tcam':
ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.low.val' may be used uninitialized in this function [-Werror=maybe-uninitialized]
ethernet/hisilicon/hns/hns_dsaf_main.c:2947:75: error: 'tbl_tcam_data.high.val' may be used uninitialized in this function [-Werror=maybe-uninitialized]

We also pass the data into hns_dsaf_tcam_mc_cfg(), which might later
use it (not sure about that), so it seems safer to just always initialize
the tbl_tcam_data structure.

Fixes: 1f5fa2dd1cfa ("net: hns: fix for promisc mode in HNS driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c