OSDN Git Service

nvmet-tcp: fix a race condition between release_queue and io_work
authorMaurizio Lombardi <mlombard@redhat.com>
Tue, 16 Nov 2021 15:49:18 +0000 (16:49 +0100)
committerChristoph Hellwig <hch@lst.de>
Tue, 23 Nov 2021 16:19:25 +0000 (17:19 +0100)
commita208fc56721775987c1b86e20d86d7e0d017c0b2
treef1298f7551961eab1f927db8ce2243a18cdafbb7
parentefcf5932230b9472cfdbe01c858726f29ac5ec7d
nvmet-tcp: fix a race condition between release_queue and io_work

If the initiator executes a reset controller operation while
performing I/O, the target kernel will crash because of a race condition
between release_queue and io_work;
nvmet_tcp_uninit_data_in_cmds() may be executed while io_work
is running, calling flush_work() was not sufficient to
prevent this because io_work could requeue itself.

Fix this bug by using cancel_work_sync() to prevent io_work
from requeuing itself and set rcv_state to NVMET_TCP_RECV_ERR to
make sure we don't receive any more data from the socket.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: John Meneghini <jmeneghi@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/tcp.c