OSDN Git Service

drm/i915/execlists: Set priority hint prior to submission
authorChris Wilson <chris@chris-wilson.co.uk>
Wed, 21 Aug 2019 14:23:36 +0000 (15:23 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 21 Aug 2019 16:32:27 +0000 (17:32 +0100)
commita20ab592d1a87218229109d109b8e2feae6f598d
treecdfae217ce0cae56dfa552ecbc849f2d6e003d48
parent6846895fde05558a39ffcee7631a802a923d9b16
drm/i915/execlists: Set priority hint prior to submission

Since we now run process_csb() outside of the engine->active.lock, we
can process a CS-event immediately upon our ELSP write. As we currently
inspect the pending queue *after* the ELSP write, there is an
opportunity for a CS-event to update the pending queue before we can
read it, making ourselves chases an invalid pointer.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111427
Fixes: df403069029d ("drm/i915/execlists: Lift process_csb() out of the irq-off spinlock")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190821142336.21609-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c