OSDN Git Service

clocksource/drivers/npcm: Fix GENMASK and timer operation
authorAvi Fishman <avifishman70@gmail.com>
Mon, 29 Jul 2019 17:03:54 +0000 (20:03 +0300)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Mon, 26 Aug 2019 22:31:39 +0000 (00:31 +0200)
commita2b58537b4a1cc08fd254fb8d1c24191ce286ae1
tree3ef3aecfc971902ba3b744c0b3542b4180e5fa2a
parent8d18f6fc75c86b2efa5865655a0630a083c8a1fd
clocksource/drivers/npcm: Fix GENMASK and timer operation

NPCM7XX_Tx_OPER GENMASK bits are wrong, fix them.

Hopefully the NPCM7XX_REG_TICR0 register reset value of those bits was 0,
so it did not cause an issue.

The function npcm7xx_timer_oneshot() reads the register
NPCM7XX_REG_TCSR0, modifies it and then reads it again overwriting the
previous changes. Remove the extra read which is pointless.

The function npcm7xx_timer_periodic() is correct but the code writes
to the NPCM7XX_REG_TICR0 register while it is dealing with the
NPCM7XX_REG_TCSR0 register, that is confusing. Separate the write to
the registers in the code for the sake of clarity.

Fixes: 1c00289ecd12 ("clocksource/drivers/npcm: Add NPCM7xx timer driver")
Signed-off-by: Avi Fishman <avifishman70@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/timer-npcm7xx.c