OSDN Git Service

drm: Replace NULL with error value in drm_prime_pages_to_sg
authorOleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Thu, 19 Jul 2018 09:37:13 +0000 (12:37 +0300)
committerOleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Mon, 23 Jul 2018 08:47:35 +0000 (11:47 +0300)
commita31ac0b23cb8ae832d49162bd217b2727154889b
tree59629abd3c28cd441818f94d70588eaa45acde8e
parent106b6c39c870c1f7628ba41693e571f419b1981d
drm: Replace NULL with error value in drm_prime_pages_to_sg

Dan Carpenter has reported that there is the following static checker
warning:
drivers/gpu/drm/drm_prime.c:317 drm_gem_map_dma_buf()
warn: 'sgt' can also be NULL

314 sgt = obj->dev->driver->gem_prime_get_sg_table(obj);
315
316 if (!IS_ERR(sgt)) {
317 if (!dma_map_sg_attrs(attach->dev, sgt->sgl, sgt->nents, dir,

Problematic functions are xen_drm_front_gem_get_sg_table and
drm_gem_cma_prime_get_sg_table. Fix those by replacing NULL with error value.

Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180719093713.3643-1-andr2000@gmail.com
drivers/gpu/drm/drm_gem_cma_helper.c
drivers/gpu/drm/xen/xen_drm_front_gem.c