OSDN Git Service

drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi
authorXin Xiong <xiongx18@fudan.edu.cn>
Sun, 19 Jul 2020 15:45:45 +0000 (23:45 +0800)
committerLyude Paul <lyude@redhat.com>
Tue, 4 Aug 2020 16:21:11 +0000 (12:21 -0400)
commita34a0a632dd991a371fec56431d73279f9c54029
treeb49ffd18b62b603fda6aeda5b788b2e70afae88a
parentd88ca7e1a27eb2df056bbf37ddef62e1c73d37ea
drm: fix drm_dp_mst_port refcount leaks in drm_dp_mst_allocate_vcpi

drm_dp_mst_allocate_vcpi() invokes
drm_dp_mst_topology_get_port_validated(), which increases the refcount
of the "port".

These reference counting issues take place in two exception handling
paths separately. Either when “slots” is less than 0 or when
drm_dp_init_vcpi() returns a negative value, the function forgets to
reduce the refcnt increased drm_dp_mst_topology_get_port_validated(),
which results in a refcount leak.

Fix these issues by pulling up the error handling when "slots" is less
than 0, and calling drm_dp_mst_topology_put_port() before termination
when drm_dp_init_vcpi() returns a negative value.

Fixes: 1e797f556c61 ("drm/dp: Split drm_dp_mst_allocate_vcpi")
Cc: <stable@vger.kernel.org> # v4.12+
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200719154545.GA41231@xin-virtual-machine
drivers/gpu/drm/drm_dp_mst_topology.c