OSDN Git Service

e1000e: Remove useless DMA-32 fallback configuration
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 9 Jan 2022 18:23:04 +0000 (19:23 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 27 Jan 2022 16:58:24 +0000 (08:58 -0800)
commita34a42d87a08052f2084891a73a86356f60f7dd4
tree77d21624bc9178fa0111563afa33de965cf94cb3
parent10ebc5464e4004ac186c922956a317d6e668cc61
e1000e: Remove useless DMA-32 fallback configuration

As stated in [1], dma_set_mask() with a 64-bit mask never fails if
dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

So, if dma_set_mask_and_coherent() succeeds, 'pci_using_dac' is known to be
1.

Simplify code and remove some dead code accordingly.

[1]: https://lkml.org/lkml/2021/6/7/398

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alexander Lobakin <alexandr.lobakin@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/e1000e/netdev.c