OSDN Git Service

omfs: fix sign confusion for bitmap loop counter
authorBob Copeland <me@bobcopeland.com>
Thu, 28 May 2015 22:44:35 +0000 (15:44 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Jun 2015 15:20:49 +0000 (08:20 -0700)
commita3593474f50b8752c03feebcd4ef0e2f7ea94a49
tree17bdb972b2dd003c21de5eb29c10e03d7e4f2b0e
parent4215727c437c76503dc668677ffdd77f233182f0
omfs: fix sign confusion for bitmap loop counter

commit c0345ee57d461343586b5e1e2f9c3c3766d07fe6 upstream.

The count variable is used to iterate down to (below) zero from the size
of the bitmap and handle the one-filling the remainder of the last
partial bitmap block.  The loop conditional expects count to be signed
in order to detect when the final block is processed, after which count
goes negative.

Unfortunately, a recent change made this unsigned along with some other
related fields.  The result of is this is that during mount,
omfs_get_imap will overrun the bitmap array and corrupt memory unless
number of blocks happens to be a multiple of 8 * blocksize.

Fix by changing count back to signed: it is guaranteed to fit in an s32
without overflow due to an enforced limit on the number of blocks in the
filesystem.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/omfs/inode.c