OSDN Git Service

drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code
authorLyude Paul <lyude@redhat.com>
Mon, 14 Nov 2022 22:17:53 +0000 (17:17 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 17 Nov 2022 05:19:18 +0000 (00:19 -0500)
commita3ae99598b9f89dd5ac9d2900fb7ffb3dcfa3d35
tree3f660a8f8c59725aebfa69c2ae844590af78ac80
parent7cce4cd628bee0d0caff7518c377cf8f599aa38f
drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code

Looks like that we're accidentally dropping a pretty important return code
here. For some reason, we just return -EINVAL if we fail to get the MST
topology state. This is wrong: error codes are important and should never
be squashed without being handled, which here seems to have the potential
to cause a deadlock.

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Fixes: 8ec046716ca8 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
Cc: <stable@vger.kernel.org> # v5.6+
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/display/drm_dp_mst_topology.c