OSDN Git Service

net-sysfs: call dev_hold if kobject_init_and_add success
authorYueHaibing <yuehaibing@huawei.com>
Tue, 19 Mar 2019 02:16:53 +0000 (10:16 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Mar 2019 20:45:58 +0000 (13:45 -0700)
commita3e23f719f5c4a38ffb3d30c8d7632a4ed8ccd9e
tree18873532e319e52799711a7bfc4bd1e8d69787c4
parent223a960c01227e4dbcb6f9fa06b47d73bda21274
net-sysfs: call dev_hold if kobject_init_and_add success

In netdev_queue_add_kobject and rx_queue_add_kobject,
if sysfs_create_group failed, kobject_put will call
netdev_queue_release to decrease dev refcont, however
dev_hold has not be called. So we will see this while
unregistering dev:

unregister_netdevice: waiting for bcsh0 to become free. Usage count = -1

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: d0d668371679 ("net: don't decrement kobj reference count on init failure")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/net-sysfs.c