OSDN Git Service

tcg/mips: mips sync* encode error
authorlixinyu <precinct@mail.ustc.edu.cn>
Sat, 11 Apr 2020 12:46:12 +0000 (20:46 +0800)
committerRichard Henderson <richard.henderson@linaro.org>
Sun, 12 Apr 2020 21:07:07 +0000 (14:07 -0700)
commita4e57084c16d5b0eff3651693fba04f26b30b551
treebbdef14b0cbc1fdc177addda6672d5e23fef76cf
parent17e1e49814096a3daaa8e5a73acd56a0f30bdc18
tcg/mips: mips sync* encode error

OPC_SYNC_WMB, OPC_SYNC_MB, OPC_SYNC_ACQUIRE, OPC_SYNC_RELEASE and
OPC_SYNC_RMB have wrong encode. According to the mips manual,
their encode should be 'OPC_SYNC | 0x?? << 6' rather than
'OPC_SYNC | 0x?? << 5'. Wrong encode can lead illegal instruction
errors. These instructions often appear with multi-threaded
simulation.

Fixes: 6f0b99104a3 ("tcg/mips: Add support for fence")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: lixinyu <precinct@mail.ustc.edu.cn>
Message-Id: <20200411124612.12560-1-precinct@mail.ustc.edu.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
tcg/mips/tcg-target.inc.c