OSDN Git Service

monitor: mark mixed functions that can suspend
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 16 Dec 2022 11:48:26 +0000 (12:48 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 20 Apr 2023 09:17:35 +0000 (11:17 +0200)
commita50c99bcc09f5f85495e365a37f8ef459405fc51
treeadee098eb3dfbe6d12b1cc330e14e79d7afc44da
parent394b9407e4c515f96df6647d629ee28cbb86f07c
monitor: mark mixed functions that can suspend

There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path.  By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn markers.  This results in more accurate checks that
coroutine code does not end up blocking.

If the marking were extended transitively to all functions that call
these ones, static analysis could be done much more efficiently.
However, this is a start and makes it possible to use vrc's path-based
searches to find potential bugs where coroutine_fns call blocking functions.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/qapi/qmp/dispatch.h
qapi/qmp-dispatch.c