OSDN Git Service

rtc: stm32: use 0 instead of ~PWR_CR_DBP in regmap_update_bits
authorAmelie Delaunay <amelie.delaunay@st.com>
Mon, 16 Jan 2017 08:57:38 +0000 (09:57 +0100)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sun, 22 Jan 2017 23:47:15 +0000 (00:47 +0100)
commita560c527638d78bc05d06585fef2d94b22b727b8
treecf2eff5660bbd6fc9456942aaccbece73d3c3599
parent5fa4086987506b2ab8c92f8f99f2295db9918856
rtc: stm32: use 0 instead of ~PWR_CR_DBP in regmap_update_bits

Using the ~ operator on a BIT() constant results in a large 'unsigned long'
constant that won't fit into an 'unsigned int' function argument on 64-bit
architectures, resulting in a harmless build warning in x86 allmodconfig:

drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe':
drivers/rtc/rtc-stm32.c:651:51: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
  regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);

As PWR_CR_DBP mask prevents other bits to be cleared, replace all
~PWR_CR_DBP by 0.

Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-stm32.c