OSDN Git Service

iwlwifi: yoyo: don't add TLV offset when reading FIFOs
authorMordechay Goodstein <mordechay.goodstein@intel.com>
Fri, 6 Mar 2020 13:16:24 +0000 (15:16 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 6 Mar 2020 13:26:32 +0000 (15:26 +0200)
commita5688e600e78f9fc68102bf0fe5c797fc2826abe
tree9ec8a095d64d72f0c8feaa99b29a2f31f5047f57
parent71bc0334a6371c7de0e0594439de7d237e4d2d03
iwlwifi: yoyo: don't add TLV offset when reading FIFOs

The TLV offset is only used to read registers, while the offset used for
the FIFO addresses are hard coded in the driver and not given by the
TLV.

If we try to apply the TLV offset when reading the FIFOs, we'll read
from invalid addresses, causing the driver to hang.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Fixes: 8d7dea25ada7 ("iwlwifi: dbg_ini: implement Rx fifos dump")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200306151129.fbab869c26fa.I4ddac20d02f9bce41855a816aa6855c89bc3874e@changeid
drivers/net/wireless/intel/iwlwifi/fw/dbg.c