OSDN Git Service

net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 10 May 2018 07:06:04 +0000 (09:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 May 2018 21:46:45 +0000 (17:46 -0400)
commita577d868b768a3baf16cdd4841ab8cfb165521d6
tree3e090ecd45bd18ae2befdb161dda260d737418ed
parent97f3efb64323beb0690576e9d74e94998ad6e82a
net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

If an error occurs, 'mlx4_en_destroy_netdev()' is called.
It then calls 'mlx4_en_free_resources()' which does the needed resources
cleanup.

So, doing some explicit kfree in the error handling path would lead to
some double kfree.

Simplify code to avoid such a case.

Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_netdev.c